P4: USB HS port#5560
Draft
bugadani wants to merge 5 commits into
Draft
Conversation
|
New commits in main have made this PR unmergeable. Please resolve the conflicts. |
5 tasks
|
New commits in main have made this PR unmergeable. Please resolve the conflicts. |
|
New commits in main have made this PR unmergeable. Please resolve the conflicts. |
c53b614 to
0115140
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The device side is sus (only works with with
embassy_usb::UsbVersion::Two), host-side seems OK. Drivers should be unified, some embassy-usb-synopsys-otg work needs to be done to enable this, as well as figuring out the quirks (extra RX FIFO depth thing).