Add release version preflight CI check#5530
Open
naoNao89 wants to merge 1 commit into
Open
Conversation
naoNao89
force-pushed
the
fix-release-version-preflight-ci
branch
2 times, most recently
from
377066c to
4f0ad12
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a release “preflight” to the xtask release execute-plan flow to prevent attempting to release crate versions that already exist on crates.io, and wires related unit tests/CI invocation.
Changes:
- Add a crates.io version existence/yank check (
ensure_versions_are_unpublished) to the release plan execution path. - Add unit tests for the helper that detects whether a target version exists in the crates.io versions list.
- Enable
reqwestfor thextaskreleasefeature and add a CI step that runs the related filtered tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
xtask/src/commands/release/execute_plan.rs |
Adds crates.io preflight querying + helper and unit tests. |
xtask/Cargo.toml |
Extends release feature to include reqwest for crates.io querying. |
.github/workflows/ci.yml |
Adds a CI step that runs the crates.io preflight-related tests. |
Comment on lines
+61
to
+62
| ensure_versions_are_unpublished(&plan)?; | ||
|
|
Comment on lines
+185
to
+188
| let client = reqwest::blocking::Client::builder() | ||
| .user_agent("esp-hal xtask release preflight") | ||
| .build() | ||
| .context("Failed to create crates.io client")?; |
Comment on lines
+275
to
+277
| - name: Check release version preflight | ||
| run: cd xtask && cargo test --features release crates_io_version | ||
|
|
naoNao89
force-pushed
the
fix-release-version-preflight-ci
branch
from
4f0ad12 to
bca10ea
Compare
naoNao89
force-pushed
the
fix-release-version-preflight-ci
branch
from
bca10ea to
c263888
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.