Conversation
Problem: Desktop push CI intermittently failed after deleting a migrated parent because a background catalog reconcile recreated a valid topic repair marker before the test's immediate absence assertion. Root cause: the test treated a transient internal marker state as a product contract even though marker invalidation exists only to trigger reconciliation and the worker may complete that reconciliation before deleteSession returns. Fix: remove the timing-sensitive marker absence assertion and retain the observable recovery visibility, identity, and project-tree assertions that fail if invalidation or reconciliation is broken. Verification: focused test passed 20 consecutive runs; focused race test passed 5 consecutive runs; gofmt and git diff --check passed.
github-actions
Bot
added
desktop
Collaborator
Author
|
This timing-only test fix has been incorporated into #10465 so the release candidate and its full Desktop matrix are validated in one pass. The product-level assertions remain: the recovered copy must become visible with the correct TopicID and appear in the project tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
main-v2push CI failed inTestCoveredRecoveryCopyBecomesVisibleAfterMigratedParentDeletionbecause it asserted that two internal migration markers were absent immediately after deletion. The background catalog worker can validly recreate signature-bound markers beforedeleteSessionreturns, so that assertion races with successful reconciliation.This removes the transient marker assertion and keeps the observable contract: deleting the covering parent must expose the recovery copy with the correct topic identity in the project tree. That final assertion still fails if marker invalidation or reconciliation is broken.
Validation:
gofmtandgit diff --check