test(diff): add coverage for formatDiff string output#16
Merged
Conversation
formatDiff was exported and called by the CLI but had no unit tests. This adds 14 cases covering: identical transcript reporting (singular and plural), onlyInA/onlyInB section headers and custom labels, changed response before/after content, summary line counts, and param truncation at the 80-char boundary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
formatDiffis exported fromsrc/diff.tsand called directly by themcprec diffCLI command, but it had zero unit tests. Any regression in its string rendering (missing sections, wrong labels, broken truncation) would go undetected by the test suite.What
test/diff.format.test.tswith 14 test cases coveringformatDiff.Tests
The new file tests
formatDiffthrough these cases:onlyInAsection: header appears, method name appears, canonical params appear, custom label replaces default "A"onlyInBsection: header appears, method name appears, custom label replaces default "B"All 136 tests pass (122 pre-existing + 14 new).
Self-merge gate
Generated by Claude Code