Skip to content
This repository was archived by the owner on Dec 1, 2025. It is now read-only.

add bzlmod support #17

Open
marcushultman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add bzlmod support #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
cc_library(
name = "linenoise-cpp",

@marcushultman marcushultman Mar 16, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linenoise.cpp cannot be used, since it presumably conflicts with the cpp file.

hdrs = [
"linenoise.h"
],
srcs = [
"linenoise.cpp",
],
visibility = ["//visibility:public"],
)
5 changes: 5 additions & 0 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
"linenoise"

module(name='linenoise.cpp', version = "0.1.0")

@sourcery-ai sourcery-ai Bot Mar 16, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Avoid using a file extension in the module name.

Module names typically represent a logical grouping; including '.cpp' may be misleading if the module contains more than just this file.

Suggested change
module(name='linenoise.cpp', version = "0.1.0")
module(name='linenoise', version = "0.1.0")


bazel_dep(name = "rules_cc", version = "0.1.1")