[DPF]: Extend and refactor 3D viewer to DataProviderFramework#987
Merged
rubenthoms merged 189 commits intoequinor:mainfrom Sep 19, 2025
Merged
[DPF]: Extend and refactor 3D viewer to DataProviderFramework#987rubenthoms merged 189 commits intoequinor:mainfrom
DataProviderFramework#987rubenthoms merged 189 commits intoequinor:mainfrom
Conversation
Also improved logic around stored data
Fix: Reverse order of seismic properties for depth slice
Anders2303
requested changes
Aug 29, 2025
Collaborator
Anders2303
left a comment
There was a problem hiding this comment.
Looks good, I see two issues in the rendering of hover-effects:
- The red line that show up is rendered with inverse z-coordinates
- The MD marker's scale is affected by the the z-scale, which does make it look pretty weird on a high value, like 10 (especially noticable on curved paths)
Screen.Recording.2025-08-29.111054.mp4
Screen.Recording.2025-08-29.112042.mp4
Anders2303
requested changes
Sep 19, 2025
Collaborator
Anders2303
left a comment
There was a problem hiding this comment.
All looks good, but in fixing the Bicone scaling issue, the earlier fix to the bicone's position was reverted.
I think all you'd need to fix it is to apply the z-scale to the center point when you render it
centerpoint[2] *= this.props.modelMatrix[10] // <--
if (this.props.modelMatrix) {
this.props.modelMatrix[10] = 1; // Prevent scaling in Z direction
}Screen.Recording.2025-09-19.084525.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main contributions
3D viewerto Data Provider Framework (DPF)dependency-cruiserto prevent cross-module imports_shareddirectory)ToggleButtonandColorTilecomponentsVisualizationAssemblerRemaining tasks:
[ ] Define seismic range as "undefined" with a given custom color (e.g. transparent)- postponed[ ] Make grid range filter a single setting which also supports zonation and region filter- postponedAdvancedWellsLayerandverticalScaleCloses #1023.
Closes #783.