Skip to content

chore: remove outdated log warnings#1434

Merged
tj098895 merged 4 commits intomainfrom
1554_remove_outdated_warnings
Apr 28, 2026
Merged

chore: remove outdated log warnings#1434
tj098895 merged 4 commits intomainfrom
1554_remove_outdated_warnings

Conversation

@tj098895
Copy link
Copy Markdown
Contributor

@tj098895 tj098895 commented Mar 13, 2026

Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

Remove old log.warning that is no longer relevant (and bonus bugfix, forgotten None-check)

What else did you consider?

Nothing.

@tj098895 tj098895 requested review from a team as code owners March 13, 2026 14:15
Comment thread src/ecalc_cli/logger.py
"maxBytes": 10000000, # 10 MB
"backupCount": 1,
"level": str(LogLevel.WARNING.value),
"level": str(self.__log_level.value),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was hardcoded on purpose, but now the log level also affects writing to file ..

flow_diagram: bool = False,
date_format_option: int = None,
logs_folder: Path = None,
log_level: str = "INFO",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to test that log file is written now as we removed all log.warning

@tj098895 tj098895 merged commit 18b9be2 into main Apr 28, 2026
23 checks passed
@tj098895 tj098895 deleted the 1554_remove_outdated_warnings branch April 28, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants