feat: add SHAFT model with MECHANICAL_EFFICIENCY for compressor trains#1332
Draft
feat: add SHAFT model with MECHANICAL_EFFICIENCY for compressor trains#1332
Conversation
f22ddc0 to
1030fb6
Compare
- Add SHAFT model type with MECHANICAL_EFFICIENCY field - Add MECHANICAL_EFFICIENCY directly to simplified trains - Add deprecation warnings for POWER_ADJUSTMENT_CONSTANT/FACTOR - Add validation for mutual exclusivity - Update documentation with migration guide
1030fb6 to
573a816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
Adds a `SHAFT` model type that compressor trains reference for mechanical efficiency. Shaft yaml object might later be used to give flexibility to let solver infer which compressors share shaft and hence speed (or speed coupling via gear ratio or similar concepts).
Changes
Example
What else did you consider?
See also: #TBD (alternative approach with direct MECHANICAL_EFFICIENCY) on train"