feat: add MECHANICAL_EFFICIENCY to compressor train types#1331
Draft
feat: add MECHANICAL_EFFICIENCY to compressor train types#1331
Conversation
5b3dce0 to
3f6dbaa
Compare
- Add mechanical_efficiency field (0 < η ≤ 1, default 1.0) to all train types - Shaft domain class owns efficiency, calculates shaft_power = gas_power / η - Mutual exclusivity with deprecated POWER_ADJUSTMENT_* params - Add docs, migration guide, and parametrized tests
3f6dbaa to
9f605fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
Summary
Add
MECHANICAL_EFFICIENCYparameter directly to all compressor train types as a physically meaningful alternative to the deprecatedPOWER_ADJUSTMENT_FACTORandPOWER_ADJUSTMENT_CONSTANTparameters.Changes
MECHANICAL_EFFICIENCYfield (0 < η ≤ 1, default 1.0) to all 4 train typesShaftdomain class to own mechanical efficiencyshaft_power = gas_power / mechanical_efficiencyin stage resultsPOWER_ADJUSTMENT_CONSTANT/FACTORExample
Supported train types
What else did you consider?
See also: #TBD (alternative approach with separate SHAFT model type referenced via SHAFT: shaft_name)