refactor: have get_max_standards_rate use set_evaluation_input for co…#1275
Closed
refactor: have get_max_standards_rate use set_evaluation_input for co…#1275
Conversation
bd9219c to
a261003
Compare
olelod
commented
Dec 8, 2025
| compressor_with_turbine_model = CompressorWithTurbineModel( | ||
| turbine_model=turbine_factory( | ||
| loads=[1, 10], efficiency_fractions=[0.5, 0.5] | ||
| loads=[1, 12], efficiency_fractions=[0.5, 0.5] |
Contributor
Author
There was a problem hiding this comment.
This test returned max_rate of 0 for all time steps because the discharge pressure was too high. Changed some values and removed some time steps.
a261003 to
6e4964f
Compare
10 tasks
6e4964f to
f6ac7cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mpressor models
Type of Work
See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044
Have you remembered and considered?
docs/drafts/next.draft.md)docs/docs/migration_guides/)BREAKING:in footer or!in headerWhat is this PR all about?
What else did you consider?
Between the lines?