Open
Conversation
Scale the built-in Prometheus response time mapping to seconds so ratelimit_service_response_time_seconds matches its name. Add a compatibility flag to preserve the legacy millisecond behavior when needed. Signed-off-by: Evgeny Evseev <evgeny@evseevs.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1101
Summary
ratelimit_server.*.response_timemapping from milliseconds to seconds soratelimit_service_response_time_secondsmatches its name and Prometheus unit conventionsPROMETHEUS_RESPONSE_TIME_AS_MILLISECONDS=trueas a compatibility switch for users who rely on the legacy built-in behaviorBreaking Change / Migration
The built-in Prometheus mapper now exports
ratelimit_service_response_time_secondsin seconds instead of milliseconds.Users who depend on the legacy built-in behavior can preserve it by setting:
This compatibility flag only affects the built-in default mapper. If PROMETHEUS_MAPPER_YAML is set, that custom mapping remains unchanged.