chore: cleanup Knip issues - #3347
Conversation
|
Warning This PR is part of a stack and targets branch 📚 Pull Request Stack
Managed by gh-stack |
590e2a6 to
d24fc8d
Compare
db5447b to
16c61c4
Compare
d24fc8d to
8bfb5b6
Compare
7d65b94 to
e09fc7a
Compare
2a0615d to
b218fd3
Compare
There was a problem hiding this comment.
I couldn't find a reference to this anywhere, and it's not a script, so.
| "@endo/ses-ava": "workspace:^", | ||
| "@endo/zip": "workspace:^", | ||
| "ava": "catalog:dev", | ||
| "c8": "catalog:dev", |
There was a problem hiding this comment.
For this sort of thing, it might be better if we actually add a reference to c8 in scripts, e.g., "test:coverage": "c8 yarn test" would be enough.
| * @param {LinkOptions} options | ||
| * @deprecated Use {@link link}. | ||
| */ | ||
| export const assemble = (compartmentMap, options) => |
There was a problem hiding this comment.
link.js is not exported, and assemble isn't used anywhere internally.
| "lint:types": "tsc" | ||
| }, | ||
| "dependencies": { | ||
| "@eslint-community/eslint-utils": "^4.7.0", |
There was a problem hiding this comment.
We're using tseslint's utils to build rules instead.
| # `import/*` namespace), while the implementation is the | ||
| # actively-maintained import-x soft fork. The pinned-exact version | ||
| # tracks security advisories on import-x. | ||
| eslint-plugin-import: 'npm:eslint-plugin-import-x@4.16.2' |
There was a problem hiding this comment.
This is only referenced in @endo/eslint-plugin now, so it doesn't need to be in the catalog.
There was a problem hiding this comment.
It was a test file without a .test.js extension!
There was a problem hiding this comment.
While all of the parser functions are exported directly from each parser implementation module, none of them are actually referenced this way.
I'd argue it doesn't make sense to try to use the parser function without its wrapper implementation.
Mostly removing unused exports.
Remove unused exports, types, and dev deps.
b218fd3 to
4d89251
Compare
e09fc7a to
b9852f7
Compare
|
|
1 participant
This PR will contain multiple commits which address Knip issues.