eos-rollback re-work#602
Draft
ikerperezdelpalomar wants to merge 3 commits intoendlessm:masterfrom
Draft
Conversation
ikerperezdelpalomar
commented
Oct 15, 2019
ikerperezdelpalomar
commented
- The eos-rollback script has been modified to became a modular program based in functions.
- A bit of error handling have been added
- A new command line argument has been added to avoid user confirmation for rollback
added 3 commits
October 15, 2019 10:33
Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
BUGFIX: Passing an empty string in aparser.parse_args() causes it to treat that string as a list of input arguments, that provoques that arguments are not being read. Signed-off-by: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
|
I don't recognize the submitter as a member of @endlessm. Can somebody in @endlessm verify the patch? See https://phabricator.endlessm.com/w/software/build/ci-integration/#pull-requests for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.