Skip to content

WRQ-9536: Fix scrolling by wheel to scroll smoothly - #1611

Draft
vJIYEv wants to merge 4 commits into
developfrom
feature/WRQ-9536
Draft

WRQ-9536: Fix scrolling by wheel to scroll smoothly#1611
vJIYEv wants to merge 4 commits into
developfrom
feature/WRQ-9536

Conversation

@vJIYEv

@vJIYEv vJIYEv commented May 16, 2024

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Scroller and VirtualList should show smooth scrolling by wheel with animation but I found scrolling by wheel shows not smooth like before.

Resolution

In scroll handler function, we have code to scroll smoothly with animation.
It runs when delta value is not 0 but default delta is 0 now in native wheel handler.
So I set default delta value to show animation.
Default delta value is came from calculated delta of the case when event target is out of scroll content.

Additional Considerations

Links

WRQ-9536

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
@codecov

codecov Bot commented May 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.59%. Comparing base (81358d5) to head (0936d35).

Files Patch % Lines
useScroll/useEvent.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1611      +/-   ##
===========================================
- Coverage    81.60%   81.59%   -0.02%     
===========================================
  Files          148      148              
  Lines         6676     6677       +1     
  Branches      1986     1986              
===========================================
  Hits          5448     5448              
- Misses         935      936       +1     
  Partials       293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmyelyn
mmyelyn marked this pull request as draft August 9, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant