WRQ-9536: Fix scrolling by wheel to scroll smoothly - #1611
Draft
vJIYEv wants to merge 4 commits into
Draft
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1611 +/- ##
===========================================
- Coverage 81.60% 81.59% -0.02%
===========================================
Files 148 148
Lines 6676 6677 +1
Branches 1986 1986
===========================================
Hits 5448 5448
- Misses 935 936 +1
Partials 293 293 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
mmyelyn
marked this pull request as draft
August 9, 2024 00:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Scroller and VirtualList should show smooth scrolling by wheel with animation but I found scrolling by wheel shows not smooth like before.
Resolution
In scroll handler function, we have code to scroll smoothly with animation.
It runs when
deltavalue is not 0 but defaultdeltais 0 now in native wheel handler.So I set default
deltavalue to show animation.Default
deltavalue is came from calculateddeltaof the case when event target is out of scroll content.Additional Considerations
Links
WRQ-9536
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)