WRQ-9559: Fix scrolling by holding pageup/down key - #1602
Open
vJIYEv wants to merge 2 commits into
Open
Conversation
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1602 +/- ##
===========================================
- Coverage 81.45% 81.43% -0.02%
===========================================
Files 148 148
Lines 6631 6632 +1
Branches 1957 1958 +1
===========================================
Hits 5401 5401
Misses 936 936
- Partials 294 295 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
SkylerBaek
reviewed
Jul 30, 2024
| node_js: | ||
| - lts/* | ||
| - node | ||
| - 21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Scrolling by holding pageup/down key works / does not work case by case.
We need to fix for all cases to show same behavior.
Resolution
Scrolling by holding pageup/down key occurs because of default behavior of browser.
But default behavior varies from browser to browser, so we can't make scroll works if default behavior is not to scroll.
To match scroll behavior of all cases, I prevented default behavior when pressed pageup/down key.
Additional Considerations
Links
WRQ-9559
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)