Skip to content

WRQ-6189: Add PageViews component - #1558

Draft
juwonjeong wants to merge 2 commits into
developfrom
feature/WRQ-6189
Draft

WRQ-6189: Add PageViews component#1558
juwonjeong wants to merge 2 commits into
developfrom
feature/WRQ-6189

Conversation

@juwonjeong

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Add PageViews component which controls showing pages with indicators and steps.

Resolution

Move the WizardPanelsRouter function from WizardPanels/WizardPanels.js to WizardPanels/utils.js file to use in the PageViews component.
Implement PageViews component view.

Additional Considerations

Links

WRQ-6189

Comments

Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
Enact-DCO-1.0-Signed-off-by: Juwon Jeong (juwon.jeong@lge.com)
@codecov

codecov Bot commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 46.96970% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.80%. Comparing base (1349503) to head (a4e7462).
⚠️ Report is 174 commits behind head on develop.

Files with missing lines Patch % Lines
PageViews/PageViews.js 0.00% 20 Missing and 8 partials ⚠️
PageViews/Page.js 0.00% 5 Missing and 1 partial ⚠️
PageViews/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1558      +/-   ##
===========================================
- Coverage    81.24%   80.80%   -0.44%     
===========================================
  Files          141      145       +4     
  Lines         6499     6534      +35     
  Branches      1921     1932      +11     
===========================================
  Hits          5280     5280              
- Misses         932      958      +26     
- Partials       287      296       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SkylerBaek SkylerBaek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We don't have specific requirements as of now, so let's keep this as-is until we'll get one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants