Skip to content

WRQ-3732: Fixed Scroller with editable prop to complete editing when focus is leaving by 5-way key on pointer mode - #1523

Draft
SkylerBaek wants to merge 2 commits into
developfrom
feature/WRQ-3732_approach_1
Draft

WRQ-3732: Fixed Scroller with editable prop to complete editing when focus is leaving by 5-way key on pointer mode#1523
SkylerBaek wants to merge 2 commits into
developfrom
feature/WRQ-3732_approach_1

Conversation

@SkylerBaek

Copy link
Copy Markdown
Member

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

In all conditions below met, focus is moving out of an editable scroller but editing mode is not completed and a selected item is kept selected;

  • The editable scroller is editing mode
  • An item is selected
  • Pointer mode
  • No item or buttons are focused by pointer
  • A user press 'enter' ('OK')

Resolution

Fixed an editable scroller logic to complete editing when the condition is detected.

Additional Considerations

Links

WRQ-3732

Comments

…hen focus is leaving by 5-way key from pointer mode

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
@codecov

codecov Bot commented Nov 30, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (e803163) to head (1e9c409).
⚠️ Report is 203 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1523   +/-   ##
========================================
  Coverage    80.40%   80.40%           
========================================
  Files          141      141           
  Lines         6488     6488           
  Branches      1917     1917           
========================================
  Hits          5217     5217           
  Misses         969      969           
  Partials       302      302           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant