Skip to content

Remove the unit test code to test codecov status check #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjro wants to merge 7 commits into
base: feature/WRP-3007
Choose a base branch
from
Open

Remove the unit test code to test codecov status check #1400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
94762cd
Remove the unit test code to test codecov status check
sjro Feb 7, 2023
80e1099
Merge branch 'develop' into feature/WRP-3007-1
sjro Feb 8, 2023
2e063fd
Remove the unit test code to test codecov status check
sjro Feb 8, 2023
6633bf0
Remove the unit test code to test codecov status check
sjro Feb 8, 2023
277bf93
Update codecov.yml
sjro Feb 8, 2023
99970e7
Merge branch 'feature/WRP-3007' into feature/WRP-3007-1
sjro Feb 8, 2023
0191aed
Update codecov.yml
sjro Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 1 addition & 54 deletions VideoPlayer/tests/VideoPlayer-specs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,65 +1,12 @@
import '@testing-library/jest-dom';
import {act, createEvent, fireEvent, render, screen, waitFor} from '@testing-library/react';
import {act, render, screen, waitFor} from '@testing-library/react';
import userEvent from '@testing-library/user-event';

import VideoPlayer from '../VideoPlayer';
import {Button} from '../../Button';
import {MediaControls} from '../../MediaPlayer';

const focus = (slider) => fireEvent.focus(slider);

describe('VideoPlayer', () => {
test('should fire `onPlaying` with `playing` type when playing event is fired', () => {
const handlePlaying = jest.fn();

render(
<VideoPlayer data-testid="videoplayer-id" onPlaying={handlePlaying} />
);

const video = screen.getByTestId('videoplayer-id');

const playingEvent = createEvent('playing', video);
fireEvent(video, playingEvent);

const expected = {type: 'playing'};
const actual = handlePlaying.mock.calls.length && handlePlaying.mock.calls[0][0];

expect(actual).toMatchObject(expected);
});

test('should fire `onControlsAvailable` with `onControlsAvailable` type when screen clicked', () => {
const handleControlsAvailable = jest.fn();

render(
<VideoPlayer data-testid="videoplayer-id" onControlsAvailable={handleControlsAvailable} />
);

const overlay = screen.getByTestId('videoplayer-id').nextElementSibling;
userEvent.click(overlay);

const slider = screen.getByRole('slider', {hidden: true});
focus(slider); // add to increase code coverage

const expected = {type: 'onControlsAvailable'};
const actual = handleControlsAvailable.mock.calls.length && handleControlsAvailable.mock.calls[0][0];

expect(actual).toMatchObject(expected);
});

test('should not to show media slider when noslider is true', async () => {
render(
<VideoPlayer data-testid="videoplayer-id" noSlider />
);

const overlay = screen.getByTestId('videoplayer-id').nextElementSibling;
userEvent.click(overlay);

await screen.findByLabelText('go to previous');

const slider = screen.queryByRole('slider', {hidden: true});
expect(slider).toBeNull();
});

test('should fire `onBack` with `onBack` type when clicking on back button', async () => {
const handleBack = jest.fn();

Expand Down
2 changes: 0 additions & 2 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,5 @@ coverage:
target: auto
threshold: 0%
# advanced settings
branches:
- feature/WRP-3007
informational: false
only_pulls: true