Skip to content

NXT-16978: Removed unused mixins#399

Merged
dan-ichim-lgp merged 5 commits into
developfrom
feature/NXT-16978
Jul 7, 2026
Merged

NXT-16978: Removed unused mixins#399
dan-ichim-lgp merged 5 commits into
developfrom
feature/NXT-16978

Conversation

@ion-andrusciac-lgp

@ion-andrusciac-lgp ion-andrusciac-lgp commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Removed unused mixins

Resolution

Additional Considerations

  • Replaced margin and padding properties with .lime-spotlight-margin and .lime-spotlight-padding mixins where it was possible

Links

NXT-16978

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac ion.andrusciac@lgepartner.com

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.59%. Comparing base (c74049e) to head (904ae57).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #399   +/-   ##
========================================
  Coverage    82.59%   82.59%           
========================================
  Files          153      153           
  Lines         7601     7601           
  Branches      2312     2312           
========================================
  Hits          6278     6278           
  Misses        1029     1029           
  Partials       294      294           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


.description {
margin: 0 @lime-spotlight-outset 1em;
.lime-spotlight-margin(0, 1rem);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check this change from em to rem ?

Comment thread samples/sampler/src/ThemeEnvironment/ThemeEnvironment.module.less Outdated
@dan-ichim-lgp
dan-ichim-lgp merged commit 0f410d9 into develop Jul 7, 2026
6 checks passed
@dan-ichim-lgp
dan-ichim-lgp deleted the feature/NXT-16978 branch July 7, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants