Improve validation of arm_type#67
Merged
Merged
Conversation
GitHub: fixes enacticGH-66 The launch script accepts several values. https://docs.openarm.dev/api-reference/description#supported-robot-versions Improve the xacro file checks to allow for these. Since `v10` was always passed downstream, it will be passed as a fixed value. Thanks for the report, sotanakamura!!!
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenArm v1.0 Xacro entrypoint to accept the same arm_type aliases supported by the launch scripts/docs (GH-66), while ensuring the internal model still uses the fixed downstream arm_type value (v10) that the v1.0 URDF expects.
Changes:
- Broaden
arm_typevalidation in the v1.0 Xacro to accept multiple v1.0/v10 aliases. - Improve the validation error message to list accepted values and include the received value.
- Pass a fixed
arm_type="v10"into the underlyingopenarm_robotmacro.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub: fixes GH-66
The launch script accepts several values.
https://docs.openarm.dev/api-reference/description#supported-robot-versions
Improve the xacro file checks to allow for these.
Since
v10was always passed downstream, it will be passed as a fixed value.Thanks for the report, sotanakamura!!!