Reuse valid search indexes without delaying notebook loading - #55
Merged
Conversation
Persist an explicit index projection profile, migrate existing indexes without discarding their last published data, and skip writes when source validity inputs still match. Move source loading and index maintenance onto independent serialized workers with source-scoped generations, cancellation, startup prioritization, and aggregate status reporting. Refs: #54
Keep startup restoration priority independent from the persisted notebook sequence, and insert asynchronously loaded notebooks at their reserved navigation positions. Preserve source order during workspace normalization and cover the prioritized-load regression at both state and GTK model boundaries. Refs: #54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Startup previously deleted and rebuilt every successfully loaded notebook's search documents, even when the source and indexed projection were unchanged. Indexing also ran on the source-loading worker, so rebuilding one notebook delayed loading the next.
The optimized startup initially prioritized the last active notebook correctly but accidentally allowed load completion order to become navigation order. This PR keeps the restored source first in the work queue while inserting completed notebooks into their persisted presentation positions.
Validation
cargo test --workspacecargo clippy --workspace --all-targets -- -D warningsscripts/validate-docs.shCloses #54
Related to #37
Builds on #38