Persist navigation expansion and pane layout - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
OneNote Viewer already restored open sources and the last page, but every restart reset the navigation tree and pane layout. The prior section and group IDs were derived from tree positions, so they were also unsuitable for durable UI state: renaming, moving, or reordering an entry could redirect saved state.
This change adopts native OneStore file identities exposed by
onenote.rs, scopes them to each source, and stores UI state in an optional versioned workspace record. Missing groups and closed or failed sources are pruned. Delayed source loading applies state only to the matching source and cannot replace a newer active selection.The parser API is proposed upstream in msiemens/onenote.rs#45. Until that is merged together with the viewer's existing image/icon dependency, the viewer pins a signed integration revision from the project fork.
User impact
After restarting, the viewer restores expanded notebooks and section groups as well as collapsed navigation panes. Existing workspace files continue to load with the established defaults.
Closes #38.
Verification
cargo test --workspace --all-targetscargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkgit diff --check