Credit the original OneNote parser author - #24
Merged
Conversation
emsi
force-pushed
the
agent/about-parser-credit
branch
2 times, most recently
from
August 7, 2026 13:53
eebf5c3 to
ad73083
Compare
emsi
force-pushed
the
agent/about-parser-credit
branch
from
August 7, 2026 13:57
ad73083 to
1a883cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populate the standard GTK About dialog's existing Credits page with a clearly labeled dependency attribution:
onenote.rsOneNote parser - originally authored by Markus SiemensThis wording distinguishes dependency authorship from OneNoteViewer authorship. The OneNoteViewer authors list remains unchanged. The About overview and System Information pages remain unchanged. No additional About page is introduced.
Validation
cargo test -p onenote-viewercargo clippy -p onenote-viewer --all-targets -- -D warningscargo fmt --all -- --check