Add mathics3#5967
Conversation
|
LGTM |
Actually I'm unclear about this part. It seems there are no architecture-dependent parts in this package when I build it here, but the packages in conda-forge are architecture dependent; see also conda-forge/mathics3-feedstock#27 (comment) |
|
OK, now it's Cythonizing |
For what it's worth, I think the introduction of Cython was a mistake, or maybe wishful thinking that Cython would somehow compensate for architectural flaws and lack of understanding or thought of what is needed. I've never seen any compelling evidence to suggest that Cython significantly improves performance, which I guess is what it is supposed to do. And overall, it has been a source of breakage, if not also complexity. But so be it. I guess I'm glad it's working now. |
|
Well if the conda-forge package is changed to architecture-independent, then I can just close this PR because those packages can be used directly in jupyterlite. conda-forge/mathics3-feedstock#27 (comment) |
|
With conda-forge/mathics3-feedstock#30 merged, this PR is no longer needed. Thanks @mmatera @rocky |
|
However, |
|
So an emscripten-forge recipe for libmagic is needed |
|
Shall we create one? |
|
Yes, let's! |
|
|
Python-magic already exists on conda-forge, and works. Maybe what is needed is lib-magic in emscript... |
|
Yes, exactly. libmagic is compiled code, so this needs a package in emscripten-forge |
|
I have libmagic ready in #5991 |
|
Looking at https://github.com/ahupp/python-magic/blob/master/magic/loader.py, the python-magic from conda-forge will not magically work though |
Template A: Checklist for adding a package
Pre-submission Checks
emscripten-wasm32platform (not a noarch package), in other words, the package requires compilation.Recipe Structure
Added
recipes/recipes_emscripten/[package-name]/recipe.yamlwith proper structure:contextsection withversion(and optionallyname)packagesection with name and version using Jinja2 templatessourcesection with:.tar.gz,.tar.bz2,.tar.xz,.tgz, or.zip)${{ version }}template for version updatescurl -sL <url> | sha256sum)[package-name]/patches/directorybuildsection with appropriate script/method${PYTHON} -m pip install . ${PIP_ARGS}$R CMD INSTALL $R_ARGS .emcmake/emmakeoremconfigure/emmakerust-nightlyandmaturinor appropriate Rust build toolrequirementssection (build, host, run as needed)testssectiontest_import_[package].pyfile created and referencedaboutsection with license, homepage, summaryPR Formatting
Add [package-name]orUpdate [package-name] to [version]Package Details
Build Notes
FYI @rocky @mmatera