Update to Emscripten 6.0.0#7
Conversation
| @@ -1 +1,3 @@ | |||
| #define PAGE_SIZE 65536 | |||
| // A value used historically in Emscripten, and which we don't have a strong | |||
| // reason to change so far. | |||
There was a problem hiding this comment.
This is the defined WebAssembly page size, so it kind of makes sense. i.e. its not just historical.
There was a problem hiding this comment.
I'll remove this comment. It looks that I synced this with getpagesize() before commit emscripten-core/emscripten@0494e29 was introduced.
There was a problem hiding this comment.
Removed with commit emscripten-core/emscripten@a62785a (and updated this PR accordingly).
|
|
||
| _Noreturn void exit(int code) | ||
| { | ||
| #ifdef _REENTRANT // XXX Emscripten: guard with _REENTRANT |
There was a problem hiding this comment.
To fix a test failure in other.test_standalone_whole_archive:
wasm-ld: error: --shared-memory is disallowed by exit.o because it was not compiled with 'atomics' or 'bulk-memory' features.
See commit emscripten-core/emscripten@3d7b8f3.
There was a problem hiding this comment.
Maybe a better fix for that would be to make libstandalonewasm into an MTLibrary?
There was a problem hiding this comment.
Ah, I thought it was a --whole-archive quirk, but you're right, we can simply make libstandalonewasm inherit from MTLibrary to fix this.
Fixed via commit emscripten-core/emscripten@abfd52c and emscripten-core/emscripten@0f0d7c0.
kleisauke
force-pushed
the
update-to-pr-26860
branch
2 times, most recently
from
a132375 to
0403aee
Compare
|
I'll wait for PR emscripten-core/emscripten#26860 to land so that I can update the PR title and commit message to "Update to emscripten 5.0.8" instead. |
kleisauke
force-pushed
the
update-to-pr-26860
branch
from
0403aee to
fa93fc9
Compare
kleisauke
changed the title
|
I'm not seeing the merging of the 'v1.2.6' musl branch here. Shouldn't here be a commit |
|
Sorry, my bad, I see in the emscripten branch already. Is this change ready to land now? |
This change was generated by running ./system/lib/push_musl_changes.py within the Emscripten repo.
kleisauke
force-pushed
the
update-to-pr-26860
branch
from
fa93fc9 to
feb499f
Compare
|
It's ready, I just updated the commit message and PR title since the next version of Emscripten will be 6.0.0 (according to the changelog). That said, perhaps we should wait until that version is released? |
|
I'm going to go ahead and land this. The "Update to .." information is never perfect here anyway. |
2 participants
This change was generated by running ./system/lib/push_musl_changes.py
within the Emscripten repo.