-
Notifications
You must be signed in to change notification settings - Fork 79
Multi fidelity acquisition functions and recommender logic #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jpenn2023
wants to merge
70
commits into
dev/mfbo
Choose a base branch
from
dev-mfbo-main-acquisition-functions
base: dev/mfbo
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
3ce4ab0
Multi fidelity searchspaces and surrogate modelling
jpenn2023 5525bb0
Typing fixes
jpenn2023 da08684
More typing fixes
jpenn2023 c0ee704
More typing fixes with some unresolved
jpenn2023 455466c
Typo fix
jpenn2023 163574b
Integrating multi fidelity surrogate models with multitask refactor
jpenn2023 8fdff67
Integrate typing
jpenn2023 55d12b0
Integrating kernel factories with multi fidelity
jpenn2023 dee1768
Move _ModelContext
jpenn2023 98b6396
Remove deprecated/unused from_preset from STMF GP.
jpenn2023 bc6bb18
Mainly docstring fixes
jpenn2023 ac1042f
Separating task and fidelity types in search space.
jpenn2023 5e1ea96
Tidying supports_ inheritance
jpenn2023 7ae620d
Remove unused imports after ModelContext move
AVHopp 14fc575
Minor fixes in `gaussian_process/utils.py`
AVHopp 013b444
Add assertion to verify that only one task resp. fidelity parameter i…
AVHopp 703232e
Fix bugs and improve code for `task_type` and `fidelity_type`
AVHopp 46f96e7
Remove unused import that were overlooked during rebase
AVHopp 55dab58
Fix incorrect formatting
AVHopp 6cf2fd2
Re-introduce `objective` and `measurements` fields to `_ModelContext`
AVHopp 70de6a7
Add support for `_ParameterKind.FIDELITY` to `from_parameters``
AVHopp 377f18e
Add validation for multiple fidelity/task parameter
AVHopp 58c30d9
Use likelihood and fit criterion factories in STMF-GP
AVHopp 81d1b16
Add fidelity type validation in `_fit`
AVHopp 0b375c7
Add construction tests for multi-fidelity surrogates
AVHopp 88046e4
Generalize `_enable_transfer_learning` to `_enable_index_kernel`
AVHopp 9cf8f6a
Add additional kernel rejection tests
AVHopp c97b68f
Generalize `__call__` of ICM Kernel to also handle fidelities
AVHopp 9403132
Generalize index kernel factory to support categorical fidelity param…
AVHopp 3d9525a
Rename `_BayBETaskKernelFactory` to `_BayBEIndexKernelFactory`
AVHopp 778d54c
Add test for fitting GaussianProcessSurrogate on categorical fidelity…
AVHopp 093336c
Auto-dispatch correct surrogate model based on the search space
AVHopp 8549b97
Use LOO for any search space that uses the IndexKernel structure
AVHopp 7597cf1
Improve docstrings
AVHopp cf60531
Adjust incorrect comments
AVHopp 74b2b07
Minor fixes to type hint and str method
AVHopp e407771
Validate surrogate fit context before caching
AVHopp 0c85748
Re-introduce `to_numpy(copy=True)` conversion
AVHopp 7673471
Re-dispatch default surrogate for changed fidelity type
AVHopp 495e466
Expose MultiFidelty model for higher level imports
AVHopp b55fcf9
Add support for fidelity parameters in Hvarfner preset
AVHopp 6d0baec
Remove unnecessary type: ignore comments
AVHopp 55a6851
Tighten ICML Kernel fidelity guard
AVHopp 088197b
Reject index-only search spaces
AVHopp cd7a5cb
Improve in-line comments
AVHopp 4bdba0c
Model-class dispatch inside `_fit`
AVHopp bdc0a3c
Revert "Model-class dispatch inside `_fit`"
AVHopp 4e50c7f
Re-create `botorch` model using our factories
AVHopp dbe5a3d
Adjust kernel mechanism to follow new botorch settings
AVHopp d57b7b4
Add acquisition functions
jpenn2023 30df5bd
Add acquisition functions
jpenn2023 a43681f
Moving generic dict comparison validator
jpenn2023 e8d1cfe
Adding qMFKG botorch attributes and including qKG current_value attri…
jpenn2023 d91fdcc
Add SearchSpaceTaskType to searchspace init file
jpenn2023 fa0caee
Add multi fidelity acqfs to acquistion init files
jpenn2023 93daff5
Add multi-fidelity acquisiton arguments
jpenn2023 c876c3f
Add recommender logic.
jpenn2023 955669f
Checkpoint files should not be in the merge.
jpenn2023 37d81eb
Attrs usage for custom acqf, minor bug fixes and docstring updates
jpenn2023 f53a5dd
Validation typing fix
jpenn2023 1abc8ae
Typing fixes: working around broad Botorch typing
jpenn2023 a298ed9
searchspace dependent acquisition function choice
jpenn2023 d05ed67
MFUCB fidelities costs and values set at acqf build time
jpenn2023 8c99f4e
Comp rep fidelity dictionary for MFUCB
jpenn2023 bc3c3b3
Restricted searchspace for MFUCB stage one
jpenn2023 d699ed9
Fixed custom acqf imports
jpenn2023 e294393
Fix typing in acqf builder
jpenn2023 992ad7a
Docstring and typing fixes.
jpenn2023 832e173
Minor fixes
jpenn2023 7aa47eb
Docstrings, error messages, variable names, file structure.
jpenn2023 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| """Custom acquisition functions.""" | ||
|
|
||
| from baybe.acquisition.custom_acqfs.two_stage import ( | ||
| MultiFidelityUpperConfidenceBound, | ||
| ) | ||
|
|
||
| __all__ = [ | ||
| # Multi fidelity acquisition functions | ||
| "MultiFidelityUpperConfidenceBound", | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.