Repository navigation
fix(admin): give list toolbars one control height - #4438
Closed
khoinguyenpham04 wants to merge 2 commits into
Closed
khoinguyenpham04 wants to merge 2 commits into
khoinguyenpham04 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: c6f48a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-test
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-loader
@emdash-cms/registry-moderation
@emdash-cms/registry-verification
upgrade-emdash
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-ai-search
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Contributor
Visual regression: 14 screens changedThese admin screens render differently on this PR. Confirm every change below is intended before accepting.
Maintainers: if every change above is intended, comment Measured head: |
Search boxes, filter selects and filter buttons on list pages came in two heights: Posts, Pages and Users used Kumo's small size while Media, Comments, Redirects, Sections, Tags and Bylines used the default. All toolbar controls now use the default height that matches the page header buttons, and TableToolbarSearch no longer takes a size. The content list's filter icons and menu options grow to fit, and the Users, Sections and Bylines filters size the same way as the others.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://noah-admin-toolbar-height.try.emdashcms.com, https://noah-admin-toolbar-height-emdash-playground.emdash-cms.workers.dev (commit c6f48a6)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
khoinguyenpham04
force-pushed
the
noah/admin-toolbar-height
branch
from
October 27, 2026 15:46
6384533 to
c6f48a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
List toolbars on the admin came in two heights:
Changes:
TableToolbarSearchuses Kumo's default size and no longer takes asizeprop, so the search box always has one height.Stacked on #4437. Design review scores for the two PRs together are in that PR.
Type of change
Your connection to this change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.Not applicable:
AI assistance disclosure
Screenshots / test output
The Media, Comments, Redirects, Sections, Tags and Bylines toolbars already used the default size, so they don't change.
Phone (390px)
Arabic
A new layout test checks that the status and date field filters keep one width whichever value is chosen. Without the fix, the status filter measures 128, 131.5 and 136.5px across its five values.
Targeted admin tests: before the width fix, 11 files and 231 tests passed (ContentList, ContentList layout, BylineFilter, MediaLibrary, media picker, Redirects, CommentInbox, Sections, TaxonomyManager, Bylines, RouterLinkButton). After it, the ContentList, ContentList layout, content list columns and router tests pass (4 files, 137 tests).