Skip to content

i18n(id): translate newly added and remaining strings - #3961

Merged
ascorbic merged 3 commits into
emdash-cms:mainfrom
Zahid09987:i18n/id-batch-8
Oct 7, 2026
Merged

ascorbic merged 3 commits into
emdash-cms:mainfrom
Zahid09987:i18n/id-batch-8

Conversation

@Zahid09987

@Zahid09987 Zahid09987 commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Translates newly added and remaining strings in packages/admin/src/locales/id/messages.po into Indonesian (id).

Closes #

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added and reviewed the user-facing changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...
  • I have included screenshots below if this PR changes the UI

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool:

Screenshots / test output

Not applicable (PO catalog update).

@changeset-bot

changeset-bot Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8731988

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/plugin-test Patch
@emdash-cms/sandbox-workerd Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
create-emdash Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the tracking.ignoredKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
packages/admin/src/locales/id/messages.po Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right kind of change: a translation-only PR that fills remaining Indonesian strings in packages/admin/src/locales/id/messages.po. The file is now structurally complete (no fuzzy entries, no truly empty msgstr entries), which matches the PR goal.

One release-blocking process issue: no changeset was added for this PR. .changeset/README.md explicitly requires a changeset for any change to a published package's behavior or API; @emdash-cms/admin is a published package in the fixed release group. The existing id-batch-7.md shows the expected pattern (patch bump for the admin package, one-line description of the Indonesian translation update). Without a new id-batch-8.md changeset, these translations will not trigger a release and the author’s own checklist item (“I have added and reviewed the user-facing changeset”) is inaccurate.

Because the diff content was elided in the provided .flue-pr.diff, I could not line-review the specific strings that were newly translated in this batch. A static scan of the file shows no structural issues (valid plural keywords, no leftover fuzzy markers), but I recommend running pnpm locale:compile and reviewing the diff against main for preserved ICU placeholders/React tags on the changed entries before merge.

Please add a .changeset/id-batch-8.md file matching the id-batch-7.md format before this PR is merged.


Findings

  • [needs fixing] .changeset/README.md:7

    The PR changes packages/admin/src/locales/id/messages.po, which is part of the published @emdash-cms/admin package, but no new changeset file was added. .changeset/README.md requires a changeset for any change to a published package's behavior or API, and the PR author already checked the changeset checklist item. Without a changeset these translations will not be released.

    Add a file such as .changeset/id-batch-8.md following the existing .changeset/id-batch-7.md pattern:

    ---
    "@emdash-cms/admin": patch
    ---
    
    Updates Indonesian (`id`) translations in the admin UI.
    

@emdashbot emdashbot Bot added review/awaiting-author Reviewed; waiting on the author to respond and removed review/needs-review No maintainer or bot review yet labels Oct 7, 2026
Updates Indonesian translations in the admin UI.
@github-actions github-actions Bot added review/needs-rereview New commits since the last review and removed review/awaiting-author Reviewed; waiting on the author to respond labels Oct 7, 2026
@emdashbot emdashbot Bot added review/approved Approved; no new commits since and removed review/needs-rereview New commits since the last review labels Oct 7, 2026
@ascorbic
ascorbic merged commit e0363c3 into emdash-cms:main Oct 7, 2026
32 checks passed
@emdashbot emdashbot Bot mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants