Repository navigation
i18n(id): translate newly added strings - #3954
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
This is a straightforward translation PR: it adds Indonesian (id) translations to packages/admin/src/locales/id/messages.po and touches no code, so there are no runtime, authorization, SQL, or logged-out-query concerns to review.
I spot-checked plural-form and placeholder-heavy entries in the catalog and did not find any ICU placeholder-name mismatches or malformed PO syntax. However, the diff payload was elided in the workspace, so I could not inspect the exact changed lines; the validation above is a static sampling of the current file rather than a line-by-line diff review.
The one concrete issue is that @emdash-cms/admin is a published package in the fixed release group, and per AGENTS.md and .changeset/README.md, a change to a published package needs a changeset. Translation updates are user-facing behavior changes, so this should have a patch changeset for @emdash-cms/admin (which, because the package is fixed, will coordinate the release with the rest of the group).
Since this is a convention omission rather than a code bug or regression, I’m leaving it as comment.
Findings
-
[needs fixing]
packages/admin/src/locales/id/messages.po:1This PR updates a published package (
@emdash-cms/admin) but does not include a changeset. Per AGENTS.md and .changeset/README.md, any change to a published package’s behavior or API needs a changeset so the release tooling can version and document it. Translation updates are user-facing behavior changes.Please add a
patchchangeset for@emdash-cms/admin:// .changeset/id-batch-7.md --- "@emdash-cms/admin": patch --- Updates Indonesian (`id`) translations in the admin UI.
Updates Indonesian translations in the admin UI.
🦋 Changeset detectedLatest commit: 3e60af6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Re-review: the prior finding is resolved.
This is a straightforward Indonesian (id) translation update for @emdash-cms/admin. Since the last review, the author added .changeset/id-batch-7.md with a patch bump for @emdash-cms/admin, which was the one convention gap in the previous pass:
---
"@emdash-cms/admin": patch
---
Updates Indonesian (`id`) translations in the admin UI.
The changeset is short, uses a present-tense verb, names the user-facing surface (Indonesian translations in the admin UI), and is appropriate for a patch-level translation batch. The package is part of the fixed release group, so the patch bump will be coordinated correctly.
I also re-checked the translation catalog statically (the diff payload was elided in the workspace, so I reviewed the full file). The PO structure is valid, all translated entries have balanced ICU braces, and the set of ICU argument names in the Indonesian msgstrs matches the source English strings (including explicit-id entries where the source is in msgstr). No placeholder mismatches or malformed plural/select blocks were found.
This PR touches no code, routes, SQL, auth, caches, or logged-out queries. With the changeset in place, I don’t see anything blocking merge.
Approved.
What does this PR do?
Translates newly added strings in
packages/admin/src/locales/id/messages.pointo Indonesian (id).Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
Not applicable (PO catalog update).