Skip to content

i18n(id): translate newly added strings - #3954

Merged
swissky merged 3 commits into
emdash-cms:mainfrom
Zahid09987:i18n/id-batch-7
Oct 7, 2026
Merged

swissky merged 3 commits into
emdash-cms:mainfrom
Zahid09987:i18n/id-batch-7

Conversation

@Zahid09987

@Zahid09987 Zahid09987 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Translates newly added strings in packages/admin/src/locales/id/messages.po into Indonesian (id).

Closes #

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added and reviewed the user-facing changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...
  • I have included screenshots below if this PR changes the UI

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool:

Screenshots / test output

Not applicable (PO catalog update).

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the tracking.ignoredKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
packages/admin/src/locales/id/messages.po Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@danielmlr danielmlr added the bot:review Trigger an emdashbot code review on this PR label Oct 7, 2026

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straightforward translation PR: it adds Indonesian (id) translations to packages/admin/src/locales/id/messages.po and touches no code, so there are no runtime, authorization, SQL, or logged-out-query concerns to review.

I spot-checked plural-form and placeholder-heavy entries in the catalog and did not find any ICU placeholder-name mismatches or malformed PO syntax. However, the diff payload was elided in the workspace, so I could not inspect the exact changed lines; the validation above is a static sampling of the current file rather than a line-by-line diff review.

The one concrete issue is that @emdash-cms/admin is a published package in the fixed release group, and per AGENTS.md and .changeset/README.md, a change to a published package needs a changeset. Translation updates are user-facing behavior changes, so this should have a patch changeset for @emdash-cms/admin (which, because the package is fixed, will coordinate the release with the rest of the group).

Since this is a convention omission rather than a code bug or regression, I’m leaving it as comment.


Findings

  • [needs fixing] packages/admin/src/locales/id/messages.po:1

    This PR updates a published package (@emdash-cms/admin) but does not include a changeset. Per AGENTS.md and .changeset/README.md, any change to a published package’s behavior or API needs a changeset so the release tooling can version and document it. Translation updates are user-facing behavior changes.

    Please add a patch changeset for @emdash-cms/admin:

    // .changeset/id-batch-7.md
    ---
    "@emdash-cms/admin": patch
    ---
    
    Updates Indonesian (`id`) translations in the admin UI.
    

@emdashbot emdashbot Bot added review/awaiting-author Reviewed; waiting on the author to respond and removed bot:review Trigger an emdashbot code review on this PR review/needs-review No maintainer or bot review yet labels Oct 7, 2026
Updates Indonesian translations in the admin UI.
@changeset-bot

changeset-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3e60af6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/plugin-test Patch
@emdash-cms/sandbox-workerd Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
create-emdash Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added review/needs-rereview New commits since the last review and removed review/awaiting-author Reviewed; waiting on the author to respond labels Oct 7, 2026
@swissky swissky added the bot:review Trigger an emdashbot code review on this PR label Oct 7, 2026

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: the prior finding is resolved.

This is a straightforward Indonesian (id) translation update for @emdash-cms/admin. Since the last review, the author added .changeset/id-batch-7.md with a patch bump for @emdash-cms/admin, which was the one convention gap in the previous pass:

---
"@emdash-cms/admin": patch
---

Updates Indonesian (`id`) translations in the admin UI.

The changeset is short, uses a present-tense verb, names the user-facing surface (Indonesian translations in the admin UI), and is appropriate for a patch-level translation batch. The package is part of the fixed release group, so the patch bump will be coordinated correctly.

I also re-checked the translation catalog statically (the diff payload was elided in the workspace, so I reviewed the full file). The PO structure is valid, all translated entries have balanced ICU braces, and the set of ICU argument names in the Indonesian msgstrs matches the source English strings (including explicit-id entries where the source is in msgstr). No placeholder mismatches or malformed plural/select blocks were found.

This PR touches no code, routes, SQL, auth, caches, or logged-out queries. With the changeset in place, I don’t see anything blocking merge.

Approved.

@emdashbot emdashbot Bot added review/approved Approved; no new commits since and removed bot:review Trigger an emdashbot code review on this PR review/needs-rereview New commits since the last review labels Oct 7, 2026
@swissky
swissky merged commit 15bbfd7 into emdash-cms:main Oct 7, 2026
35 checks passed
@emdashbot emdashbot Bot mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants