Repository navigation
Fresh installs get tiptap 3.32, where admin editor tests fail, but CI only tests 3.20 #4400
Description
Description
@emdash-cms/admin and emdash ask for @tiptap/* ^3.20.0, so a fresh install gets tiptap 3.32.0. The repo's lockfile pins 3.20.0, so CI only ever tests the editor on 3.20. That's how #4367, #4392 and #4393 got through: each one only shows on newer tiptap.
On main, the admin editor tests pass on 3.20.0. On 3.32.0, 15 fail. #4396 fixes eight of them (the floating toolbars from #4392). With #4396 applied, these seven still fail:
- Code block highlighting: the three syntax tests in
CodeBlockNode.test.tsfind no highlighted tokens. The editor itself still highlights code on 3.32.0. These tests build an editor without React, and on 3.32.0 the code block's React view renders nothing there. - Select all: after
selectAll(), the images don't get theProseMirror-selectednodeclass, so the image settings test fails before it opens anything. - Table width: in two tests in
table-resize.test.tsx, the table's inline width is the sum of its column widths (288px,10px) instead of100%. Since fix(extension-table): update colgroup for non-resizable tables ueberdosis/tiptap#7786, tiptap's table extension adds its own table view whenresizableis off, and the editor uses it instead of emdash'sResponsiveTableView. - Links: in "applies a link to text typed after an empty caret", the link ends after "linked" and leaves " text" outside it. Tiptap now ends a link at a space typed after it, on purpose (fix(link): backport space termination after links to v3 ueberdosis/tiptap#8351).
I think these should be fixed together with moving the catalog to 3.32.0, so CI tests what people actually install.
Steps to reproduce
- In a checkout of
main, change each^3.20.0among the@tiptap/*entries of thepnpm-workspace.yamlcatalog to3.32.0. Leave@tiptap/extension-code-block-lowlightat its pinned3.20.0, as a fresh install does. - Run
pnpm install,pnpm dedupeandpnpm build. - In
packages/admin, runnpx vitest run tests/editor. 15 tests fail. - Apply fix(editor): keep floating toolbar events on React-owned surfaces #4396 (
gh pr diff 4396 -R emdash-cms/emdash | git apply) and run the tests again. Seven fail.
In some runs, one or two link tests in toolbar.test.tsx fail as well, on 3.20.0 too. They select all the text and then click "Add link" or "Edit link". If the floating format toolbar has opened by then, the test finds two of those buttons.
Environment
- emdash:
mainat 20a5923 (admin 1.3.1) - @tiptap/*: 3.32.0 (fails), 3.20.0 (passes)
- Node.js: 24.21.0
- Runtime: the admin's browser tests (Vitest with Playwright Chromium)
- OS: macOS
Screenshots
Not applicable.
Logs / error output
CodeBlockNode.test.ts > renders syntax tokens for javascript
AssertionError: expected 0 to be greater than 0
image-toolbar.test.tsx > opens and closes the image's settings, also after selecting everything
AssertionError: expected to have a length of 2 but got +0
table-resize.test.tsx > renders a fluid table with a numeric preferred minimum width
AssertionError: expected '288px' to be '100%'
toolbar.test.tsx > applies a link to text typed after an empty caret
AssertionError: expected 'linked' to be 'linked text'Written with help from Claude (Opus 5.5); I reproduced it myself.
Activity
emdash-autofix commentedon Oct 25, 2026
The EmDash bot's work on this issue continues in #4401.
emdash-autofix commentedon Oct 25, 2026
@danielmlr Could you try the preview or the package builds and confirm whether they resolve the Tiptap 3.32 failures you reported?
Affected packages:
This preview includes the dependency update, responsive table fix, toolbar compatibility fixes, and updated test harnesses/expectations. A follow-up for inline-menu positioning after closing the link field has also been submitted, but is not included in this preview commit yet.
emdash-autofix commentedon Oct 25, 2026
Correction: the
emdashpackage URL ishttps://pkg.pr.new/emdash-cms/emdash@1ce5e56(without the extra/emdashin the command above). The admin package URL is unchanged.emdash-autofix commentedon Oct 25, 2026
@danielmlr The preview now includes the inline-menu positioning and accessibility follow-ups. All required checks pass, and review is clean. Could you confirm whether this version resolves the failures you reported?
Latest affected package builds: