#1467 - Removed explicitely setting the ArchUnit version 1.3.0. Now it will be picked up from the embabel-build-dependencies that now sets the ArchUnit version to 1.4.0

[simeshev]

This pull request is gated by embabel/embabel-build#78

[Copilot]

Pull request overview

Removes the archunit.version override from embabel-agent-api so the ArchUnit version is provided by the upstream dependency/BOM (per the gated embabel-build change), aligning this module with centrally managed dependency versions.

Changes:

• Removed the module-level <archunit.version>1.3.0</archunit.version> property override so ArchUnit is resolved from the parent dependency management (targeting 1.4.0 via embabel-build-dependencies).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[igordayen]

This pull request is gated by embabel/embabel-build#78

@simeshev - could you share evidemce:
a. mvn dep:tree
b. AchUnit regression run (will fail with functiional exceptions most likely)

Thank you

[alexheifetz]

Looks Good. Tnx. Please follow up on @igordayen feedback and we will merge.

[igordayen]

PR: embabel/embabel-build#78 should be merged prior to this PR

[simeshev]

@igordayen

Below is the comparison of the the resolved Maven dependency tree at 1.3.0 and 1.4.2 after installing the change to embabel-build with ArchUnit 1.4.2.

Effective dependency changes

No artifacts were added or removed. The resolved graph shape is unchanged; only versions changed.

Before (1.3.0):

com.tngtech.archunit:archunit-junit5:1.3.0
+- com.tngtech.archunit:archunit-junit5-api:1.3.0
|  \- com.tngtech.archunit:archunit:1.3.0
|     \- org.slf4j:slf4j-api:2.0.12
\- com.tngtech.archunit:archunit-junit5-engine:1.3.0
   \- com.tngtech.archunit:archunit-junit5-engine-api:1.3.0
      \- org.junit.platform:junit-platform-engine:1.10.2
         +- org.opentest4j:opentest4j:1.3.0
         +- org.junit.platform:junit-platform-commons:1.10.2
         \- org.apiguardian:apiguardian-api:1.1.2

After (1.4.2):

com.tngtech.archunit:archunit-junit5:1.4.2
+- com.tngtech.archunit:archunit-junit5-api:1.4.2
|  \- com.tngtech.archunit:archunit:1.4.2
|     \- org.slf4j:slf4j-api:2.0.17
\- com.tngtech.archunit:archunit-junit5-engine:1.4.2
   \- com.tngtech.archunit:archunit-junit5-engine-api:1.4.2
      \- org.junit.platform:junit-platform-engine:1.14.2
         +- org.opentest4j:opentest4j:1.3.0
         +- org.junit.platform:junit-platform-commons:1.14.2
         \- org.apiguardian:apiguardian-api:1.1.2

Delta

• com.tngtech.archunit:archunit-junit5 1.3.0 -> 1.4.2
• com.tngtech.archunit:archunit-junit5-api 1.3.0 -> 1.4.2
• com.tngtech.archunit:archunit 1.3.0 -> 1.4.2
• com.tngtech.archunit:archunit-junit5-engine 1.3.0 -> 1.4.2
• com.tngtech.archunit:archunit-junit5-engine-api 1.3.0 -> 1.4.2
• org.slf4j:slf4j-api 2.0.12 -> 2.0.17
• org.junit.platform:junit-platform-engine 1.10.2 -> 1.14.2
• org.junit.platform:junit-platform-commons 1.10.2 -> 1.14.2
• Unchanged: org.opentest4j:opentest4j:1.3.0
• Unchanged: org.apiguardian:apiguardian-api:1.1.2

[igordayen]

@simeshev - thats good. Please execute regression testing:
mvn test -Dtest=ThreadSafetyRulesTest -Dsurefire.failIfNoSpecifiedTests=false >/tmp/arch-rules

Also - please confirm evidence above results from updating embabel-build locally.

If yes, then this PR should go after embabel-build merge.

Thanks

[igordayen]

Please sign commit, thanks

and confirm JVM version used in testing, please