Skip to content

Fix toTitleCase to support Unicode and non-English alphabets Fixes #37 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanjdlt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix toTitleCase to support Unicode and non-English alphabets Fixes #37 #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/String/Extra.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,11 @@ toTitleCase : String -> String
toTitleCase ws =
let
uppercaseMatch =
Regex.replace (regexFromString "\\w+") (.match >> toSentenceCase)
Regex.replace (regexFromString "\\S+") (.match >> toSentenceCase)
in
ws
|> Regex.replace
(regexFromString "^([a-z])|\\s+([a-z])")
(regexFromString "^(.)|\\s+(.)")
(.match >> uppercaseMatch)


Expand Down
13 changes: 13 additions & 0 deletions tests/Tests.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,19 @@ toTitleCaseTest =
|> String.length
in
Expect.equal expected result
, test "Works with accented characters" <|
\_ ->
Expect.equal "Álbum De Fotos" (toTitleCase "álbum de fotos")
, test "works with ñ" <|
\() ->
Expect.equal "El Niño" (toTitleCase "el Niño")
, test "works with French accents" <|
\() ->
Expect.equal "École De Paris" (toTitleCase "école de paris")
, test "works with fully accented phrase" <|
\() ->
Expect.equal "Ángel Éxtasis Ícono Ópera Único"
(toTitleCase "ángel éxtasis ícono ópera único")
]


Expand Down