Skip to content

Add Faker.String.hexadecimal/1 #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ilyashuma wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Faker.String.hexadecimal/1 #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6c7df9
Add Faker.String.hexadecimal/1
ilyashuma May 12, 2020
9a8d1ef
Merge branch 'master' into enhancement/string
ilyashuma May 12, 2020
76fab8b
Merge branch 'master' into enhancement/string
anthonator Jul 2, 2020
c170d70
Merge branch 'master' into enhancement/string
ilyashuma Sep 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ Change log itself follows [Keep a CHANGELOG](http://keepachangelog.com) format.
- `Faker.Gov.It` [[@neslinesli93](https://github.com/neslinesli93)]
- `Faker.Vehicle.model/1` [[@daytonn](https://github.com/daytonn)]
- `Faker.Person`[[@anthonator](https://github.com/anthonator)]
- `Faker.String.hexadecimal/0` and `Faker.String.hexadecimal/1`[[@ilyashuma](https://github.com/ilyashuma)]

### Changed
- Fix `Faker.Code.Iban.iban` and `Faker.Gov.It.fiscal_id` doctests [[@vbrazo](https://github.com/vbrazo)]
Expand Down
20 changes: 20 additions & 0 deletions lib/faker/string.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,24 @@ defmodule Faker.String do
|> Base.encode64()
|> binary_part(0, length)
end

@doc """
Returns a random hexadecimal String
## Examples
iex> Faker.String.hexadecimal()

@vbrazo vbrazo May 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it returns a String, hexadecimal is a number according to its definition.

Suggested change
iex> Faker.String.hexadecimal()
iex> Faker.Number.hexadecimal()

@vbrazo vbrazo May 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is Faker Ruby reference.

"d6d98b88c866f496dbd4de7ba48d0f52"
iex> Faker.String.hexadecimal()
"c9edd02cc9f381def9d922a146bf8550"
iex> Faker.String.hexadecimal(5)
"9b5c2"
iex> Faker.String.hexadecimal(100)
"9a3a4993ad56b778dc26eddb7e0c2e49c4e638e62de32933bc3525bb4594a1a378dc29f741dd703efd94dd3b6d08feaa53a9"
"""
@spec hexadecimal(pos_integer) :: String.t()
def hexadecimal(length \\ 32) do
length
|> Faker.random_bytes()
|> Base.encode16(case: :lower)
|> binary_part(0, length)
end
end