Skip to content

Implement Req Client - #90

Open
slashmili wants to merge 7 commits into
elixir-broadway:mainfrom
slashmili:req-sqs-client-73
Open

Implement Req Client#90
slashmili wants to merge 7 commits into
elixir-broadway:mainfrom
slashmili:req-sqs-client-73

Conversation

@slashmili

@slashmili slashmili commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

closes #88, #73 and potentially #11

I tested consuming messages from AWS SQS directly.

IMO this change should be considerd as breaking change and bump the major version, we can also bump to 0.8.0 and assume people update accordingly

@slashmili
slashmili force-pushed the req-sqs-client-73 branch 4 times, most recently from 483b8e0 to 1f0fc84 Compare August 12, 2026 07:31
@slashmili
slashmili marked this pull request as ready for review August 12, 2026 07:40

@wojtekmach wojtekmach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left some comments below.

Comment thread examples/sqs_example/config/config.exs Outdated
Comment thread mix.exs
Comment thread lib/broadway_sqs/req_client/request.ex Outdated
Comment thread test/broadway_sqs/req_client/request_test.exs Outdated
Comment thread lib/broadway_sqs/req_client.ex
@slashmili
slashmili force-pushed the req-sqs-client-73 branch 2 times, most recently from 9214867 to b60938c Compare August 12, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use JSON for parsing when added upstream

2 participants