feat(flterm): expose accessible terminal semantics - #102
Open
adonm wants to merge 1 commit into
Open
Conversation
adonm
force-pushed
the
upstream/101-accessibility
branch
from
August 15, 2026 22:36
ed9a137 to
2b8ca42
Compare
adonm
force-pushed
the
upstream/101-accessibility
branch
from
August 15, 2026 22:49
2b8ca42 to
ef585ed
Compare
Author
|
Local validation on the pinned Flutter beta: |
Port the accessibility semantics node onto the controller/view input pipeline. TerminalView gains semanticsLabel/semanticsHint params with sensible defaults; setting semanticsLabel to null delegates the accessible surface to an embedding application. The semantics node exposes the visible, non-concealed terminal viewport as plain text (wide cells widened, SGR 8 invisible cells omitted, wrapped rows joined), captured from the render pipeline after each paint and coalesced through a bounded 100 ms refresh interval so output updates never announce as a live region. The snapshot follows the visible scrollback viewport (primary screen only), and switching controllers clears the cached value. Focus/tap actions route to terminal input focus. This was carried downstream in the Zuko remote-shell client and is ported here onto the refactored frame-source pipeline.
adonm
force-pushed
the
upstream/101-accessibility
branch
from
August 26, 2026 07:42
ef585ed to
c6e2bf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a screen-reader semantics node to
TerminalView:semanticsLabel/semanticsHintparams with sensible defaults ('Terminal'/'Activate to focus terminal input'). SetsemanticsLabel: nullto delegate the accessible surface to an embedding application.July 2026 update: reworked onto current
mainThis branch has been rebased onto
mainafter the controller/view boundary refactors (#143, #144) and reworked for the current frame-source pipeline:FrameBuilder.semanticsText()walks the currentRowIterator/CellIteratorstate;RenderPipelineforwards it.TerminalRenderer/render box capture the snapshot after frame sync when asemanticsGenerationadvances.TerminalViewowns the generation bumps (terminal output, primary-screen scroll, controller swap) and theValueNotifier-driven semantics node.Verification
dart format --set-exit-if-changed packages/fltermanddart analyze packages/flterm: clean (only 2 pre-existing info lints undertool/benchmarks).Carried downstream in the Zuko remote-shell client since flterm 0.0.4; this is the port onto the refactored pipeline.