Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how command arguments are handled to resolve DEP0190 by moving the arguments into the command string and simplifying the function signatures.
- Removed the separate args parameter from run and forget functions in runner.ts.
- Updated usage of run() in runUrl, create, and tryOpenVSCode commands to pass a single command string.
- Updated Node.js version in GitHub workflows to 20.19.0.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/common/runner.ts | Removed the args parameter and consolidated arguments into command strings; updated runUrl accordingly. |
| src/commands/create.ts | Updated dependency installation and build commands by using string interpolation for the command. |
| .github/workflows/release.yml | Updated Node.js version from 20.15.0 to 20.19.0. |
| .github/workflows/build.yml | Updated Node.js version from 20.15.0 to 20.19.0. |
Comments suppressed due to low confidence (2)
src/commands/create.ts:45
- [nitpick] The renamed variable
npmmay be ambiguous if the package manager is not necessarily npm; consider using a more descriptive name likepackageManagerCmd.
const { packageManager: npm } = getConfig();
src/common/runner.ts:46
- When constructing command strings by concatenation (e.g., using
start ${url}andopen ${url} -g), ensure that theurlparameter is properly sanitized to prevent potential shell injection vulnerabilities.
if (platform() === "win32") {
ChekTek
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.