fix(ci): drop the blocked third-party Rust setup action - #114
Merged
Conversation
Every ci.yml run has been failing at startup (`startup_failure`), so no check/compile/test has ever actually run in this repo — including on the regeneration PRs. Cause: the org restricts Actions to an allowlist (`allowed_actions: selected`, `verified_allowed: false`), and `actions-rust-lang/setup-rust-toolchain` is not on it. Referencing a disallowed action fails the whole workflow before any job starts, which is why release.yml (only `actions/*`, GitHub-owned) works while ci.yml never did. The GitHub-hosted ubuntu runners already ship a stable Rust toolchain, so drop the setup action and use it directly, printing the version for debuggability. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
They only printed toolchain versions and were duplicated across all three jobs; a missing toolchain would fail `cargo check` with a clear error anyway, and the runner image version is already in the log header. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
No CI has ever run in this repo. Every
ci.ymlrun — onnext, on the regeneration PRs, on every feature branch — ends instartup_failure:Cause
The org restricts GitHub Actions to an allowlist:
{ "allowed_actions": "selected", "github_owned_allowed": true, "verified_allowed": false, "patterns_allowed": ["elevenlabs/actions/*", "pnpm/action-setup@*", ...] }actions-rust-lang/setup-rust-toolchainisn't on it. Referencing a disallowed action fails the entire workflow before any job starts — which is exactly whyrelease.ymlworks (it only uses GitHub-ownedactions/*) whileci.ymlnever has.Fix
The GitHub-hosted ubuntu runners already ship a stable Rust toolchain, so the setup action isn't needed. Removed it and use
cargodirectly, printingrustc/cargo --versionfor debuggability. Added a comment so nobody reintroduces a blocked action.This PR is self-verifying: for same-repo PRs the
pull_requestevent runs the workflow from the PR branch, so if CI goes green here, the fix works.Why this matters now
PR #112 added a
pull_requesttrigger and steps to run the generated crates' 146 previously-unrun tests. That trigger fires correctly — but the workflow still couldn't start. With this fix, all of it actually executes: 1913 tests across the framework, workflow, and both generated crates.Possible follow-up
The three jobs each rebuild from scratch.
actions/cacheis GitHub-owned (so allowlisted) and could cache~/.cargo+target/— happy to add if the runtime is annoying.🤖 Generated with Claude Code