CORE-780: pin urllib3 to 2.7.0 for Dependabot high alerts#2229
Conversation
Adds an explicit `urllib3>=2.7.0,<3.0.0` constraint to pyproject.toml to address two open Dependabot high-severity alerts. urllib3 is a transitive dep (via `requests` and `boto3`), and without a lock file this constraint is the canonical way to ensure consumers install the fixed version. CVEs addressed: - GHSA-mf9v-mfxr-j63j: Decompression-bomb safeguards bypassed in parts of the streaming API (vulnerable >=2.6.0,<2.7.0) - urllib3: Sensitive headers forwarded across origins in proxied low-level redirects (vulnerable >=1.23,<2.7.0) [run-e2e] Co-Authored-By: Noy Arie <noyarie1992@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @NoyaArie |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds an explicit dependency constraint for ChangesDependency Management
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Adds an explicit
urllib3 = ">=2.7.0,<3.0.0"constraint topyproject.tomlto address two open Dependabot high-severity alerts.urllib3is a transitive dep here (viarequestsandboto3); since this repo has nopoetry.lockchecked in, an explicit constraint inpyproject.tomlis the canonical way to ensure consumers (pip install elementary-data) install the fixed version.CVEs addressed:
>=2.6.0,<2.7.0).>=1.23,<2.7.0).Version-only PR — no code changes. urllib3 is only used transitively (no direct imports in the codebase).
Linear: CORE-780.
Review & Testing Checklist for Human
[run-e2e]).pyproject.tomlconstraint is compatible withrequests>=2.28.1,<3.0.0(it is —requestsonly requiresurllib3>=1.21.1,<3).Notes
Link to Devin session: https://app.devin.ai/sessions/84074f4ff245446a97461691ad950635
Requested by: @NoyaArie
Summary by CodeRabbit