ci: remove unused GCS_KEYFILE from test-warehouse workflow#2213
Conversation
Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
👋 @devin-ai-integration[bot] |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe test warehouse workflow removes unused Google Cloud service account keyfile generation from secrets and eliminates two commented-out GCS upload parameters from the report delivery command, streamlining the workflow configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Remove the unused GCS_KEYFILE secret and related GCS references from the
test-warehouse.ymlworkflow.Changes:
GCS_KEYFILEto/tmp/gcs_keyfile.json--google-service-account-pathand--gcs-bucket-nameflags from thesend-reportstepThe GCS upload was already disabled (commented out), so this is a cleanup-only change with no functional impact.
Review & Testing Checklist for Human
Notes
The
GCS_KEYFILEsecret reference and the commented-out GCS flags were dead code — the report upload only uses S3 and Azure today.Link to Devin session: https://app.devin.ai/sessions/3745da6a144342e68d7a35a6f02092ff
Requested by: @haritamar
Summary by CodeRabbit