Conversation
Contributor
🤖 GitHub commentsJust comment with:
|
2 tasks
mashhurs
reviewed
Apr 7, 2026
Contributor
mashhurs
left a comment
There was a problem hiding this comment.
clean backport, will hold merging till gemfile.lock land
💚 Build Succeeded
cc @mashhurs |
mashhurs
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
What does this PR do?
DLQ flush operation is heavy, under the hood
DeadLetterQueueUtils#extractSegmentIdwill be called. TheString#splitis also CPU intensive that internally utilizesPattern#compile. Since the logic is simple, it can be replaceable withindexOfandsubstring.Why is it important/What is the impact to the user?
A bit performance improvement when using DLQ.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Functionality test can be done by enabling DLQ and changing its settings, such as make size small to make DLQ full.
But performance measurement is a bit hard on powerful machines, so here is the benchmark - #18883
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #18874 done by [Mergify](https://mergify.com).