Skip to content

[9.2] Add deprecated JDK cipher to release notes#18948

Open
mashhurs wants to merge 2 commits intoelastic:9.2from
mashhurs:add-cipher-note-9.2
Open

[9.2] Add deprecated JDK cipher to release notes#18948
mashhurs wants to merge 2 commits intoelastic:9.2from
mashhurs:add-cipher-note-9.2

Conversation

@mashhurs
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs commented Apr 6, 2026

Release notes

[rn:skip]

What does this PR do?

Why is it important/What is the impact to the user?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)
  • run exhaustive tests : Run the exhaustive tests Buildkite pipeline.

@mashhurs
Copy link
Copy Markdown
Contributor Author

mashhurs commented Apr 6, 2026

doc-ci didn't show the preview, will close and re-open if it triggers

@mashhurs mashhurs closed this Apr 6, 2026
@mashhurs mashhurs reopened this Apr 6, 2026
@mashhurs
Copy link
Copy Markdown
Contributor Author

mashhurs commented Apr 6, 2026

@elasticmachine run docs build

@mashhurs
Copy link
Copy Markdown
Contributor Author

mashhurs commented Apr 6, 2026

run docs-build

@mashhurs mashhurs changed the title Add deprecated sipher note to 9.2.7 release note. [9.2] Add deprecated JDK cipher to release notes Apr 6, 2026
@mashhurs
Copy link
Copy Markdown
Contributor Author

mashhurs commented Apr 7, 2026

@Mpdreamz I am experiencing that previews are not available. doc-ci seems doesn't catch the changes: pull/18948 in logstash has no docs changes compared to 9.2. Something impacted by this PR - #18915, can you please check?

fyi: same situation with #18949

@donoghuc
Copy link
Copy Markdown
Member

donoghuc commented Apr 7, 2026

Looks like the diff computation only looks for .asciidoc extension files changed https://github.com/elastic/docs/blob/22dad3593cf294009fe1e7fd60a0b8dfb5b56c56/.buildkite/scripts/build_pr.sh#L71 . 9.x/main use .md files.

@mashhurs
Copy link
Copy Markdown
Contributor Author

mashhurs commented Apr 7, 2026

Looks like the diff computation only looks for .asciidoc extension files changed https://github.com/elastic/docs/blob/22dad3593cf294009fe1e7fd60a0b8dfb5b56c56/.buildkite/scripts/build_pr.sh#L71 . 9.x/main use .md files.

Yeah, the no change found message is coming from https://github.com/elastic/docs/blob/22dad3593cf294009fe1e7fd60a0b8dfb5b56c56/.buildkite/scripts/build_pr.sh#L210 but I was still expecting our old LS action to run - https://github.com/elastic/logstash/actions/workflows/docs-build.yml, it didn't run on this PR 🤷 and I am thinking it should be because of this change - #18915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants