[9.3] (backport #18919) Improve xpack integration test UX#18934
Open
mergify[bot] wants to merge 1 commit into9.3from
Open
[9.3] (backport #18919) Improve xpack integration test UX#18934mergify[bot] wants to merge 1 commit into9.3from
mergify[bot] wants to merge 1 commit into9.3from
Conversation
- Make ES and Filebeat extraction incremental. copyEs and copyFilebeat now declare inputs / outputs so Gradle skips re-extraction when the tar.gz is unchanged. - Support running a single xpack spec via `-PrubyIntegrationSpecs` to align with core. Example: `./gradlew :logstash-xpack:rubyIntegrationTests -PrubyIntegrationSpecs=qa/integration/monitoring/monitoring_is_disabled_spec.rb` (cherry picked from commit fcfcea0) # Conflicts: # x-pack/AGENTS.md
Contributor
Author
|
Cherry-pick of fcfcea0 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Contributor
🤖 GitHub commentsJust comment with:
|
3 tasks
💛 Build succeeded, but was flaky
Failed CI Stepscc @kaisecheng |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @kaisecheng? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three improvements to the Gradle xpack integration test workflow:
copyEsandcopyFilebeatnow declareinputs/outputsso Gradle skips re-extraction when the tar.gz is unchanged.-PrubyIntegrationSpecs=instead of the fullqa/integrationsuite.How to test this PR locally
./gradlew :logstash-xpack:rubyIntegrationTests -PrubyIntegrationSpecs=qa/integration/monitoring/monitoring_is_disabled_spec.rb. Only that spec runs../gradlew :logstash-xpack:rubyIntegrationTests -PrubyIntegrationSpecs=qa/integration/monitoring/monitoring_is_disabled_spec.rb. ES is NOT re-downloaded on second run../gradlew :logstash-xpack:rubyIntegrationTests. All specs run. ES and Filebeat extracted correctly.This is an automatic backport of pull request Improve xpack integration test UX #18919 done by Mergify.