fix: use correct storage path in run_benchmark.py#134
Open
Aneesh-382005 wants to merge 1 commit into
Open
Conversation
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmarks/run_benchmark.pywas missed in #106. It still usesPath(config.storage_path) / project_dir.nameinstead ofproject_storage_dir(), so it looks in a different directory than where the index is written (<name>-<hash>). Because of that, every benchmark query returns 0 results.came back as a MISS with 0 tokens until I traced it to this mismatch.
Fix
Use the same
project_storage_dir()helper the indexer already uses.Test plan
python benchmarks/run_benchmark.py --repo https://github.com/expressjs/express.git --source-dir libbefore the fix: all 20 queries MISS, 0% everywherebenchmarks/results/fastapi.md,fiber.md,chi.mdwere generated before fix: hashed storage paths to prevent basename collisions #106 landed and are stale relative to currentmain, though still historically valid. Happy to rerun them if useful.