Fix core properties namespace conflict - #657
Open
JackSpiece wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing
docxtplalso importsdocxcomposewhen the subdocument extra is installed.docxcompose.utilschanges the process-wide python-docxnsmap["cp"]entry to the custom-properties namespace. Later core-property assignments then append an element in that namespace instead of updating the existing core property.This restores the standard core-properties mapping after the docxcompose imports. docxcompose keeps its own
NSmapping, so its custom-property and subdocument behavior is unchanged.The regression test renders a template, sets
keywords, then inspectsdocProps/core.xmland verifies there is exactly one keyword element in the standard core-properties namespace.Fixes #471
Verification