feat: removing enterprise code and adding DashboardContextEnricher#270
feat: removing enterprise code and adding DashboardContextEnricher#270kiram15 wants to merge 1 commit intorelease-ulmofrom
Conversation
|
Thank you for your pull request! Congratulations on completing the Open edX tutorial! A team member will be by to take a look shortly. |
There was a problem hiding this comment.
Pull request overview
This PR removes Enterprise-specific context construction from the LMS learner dashboard and account activation email flow, shifting Enterprise dashboard context injection to an Open edX Filters pipeline step (DashboardContextEnricher) and removing the legacy dashboard consent-link UI.
Changes:
- Remove
enterprise_support/Enterprise context wiring fromstudent_dashboardandcompose_activation_email/activate_account. - Remove the legacy “consent required courses” helper (
get_consent_required_courses) and associated tests/UI templates. - Add an
OPEN_EDX_FILTERS_CONFIGdefault configuration enabling the dashboard render filter pipeline step.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openedx/features/enterprise_support/tests/test_api.py | Removes tests for the deleted get_consent_required_courses helper. |
| openedx/features/enterprise_support/api.py | Removes the get_consent_required_courses API helper. |
| openedx/core/djangoapps/user_authn/tests/test_tasks.py | Updates activation email context expectations after removing enterprise context key. |
| lms/templates/dashboard/_dashboard_show_consent.html | Deletes the legacy consent CTA message template. |
| lms/templates/dashboard/_dashboard_course_listing.html | Removes inclusion/args for the deleted consent CTA block. |
| lms/templates/dashboard.html | Removes per-course consent-link wiring from dashboard rendering. |
| lms/envs/common.py | Introduces OPEN_EDX_FILTERS_CONFIG to run the enterprise dashboard context enricher step. |
| common/djangoapps/student/views/management.py | Removes enterprise learner context and redirect special-casing. |
| common/djangoapps/student/views/dashboard.py | Removes enterprise context creation prior to DashboardRenderStarted.run_filter(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
❌ I see that many of the issues raised (and fixed) in the sibling PR are still present here. One practical reason to keep your PRs one single commit (especially these platform ones) is so that it simplifies cherry-picking between them. Trying to keep these two PRs synchronized is burdened by the overhead of merge commits and fixup commits which pollute the history. |
Description
Supporting information
ENT-11569
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.