Stop the annotations vignette querying audioBlast as it builds - #32
Merged
Merged
Conversation
The chunk fetching annotations from audioBlast was evaluated as the vignette was built, so R CMD build failed outright wherever the API answers R with a 403, which is the same problem the tests had. The chunk is now eval=FALSE, like the BirdNET chunk below it, as it only demonstrates the call: the object it assigns is reassigned before anything uses it. R CMD check is now Status: OK, with vignettes built and no NOTEs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 83.51% 83.51%
=======================================
Files 88 88
Lines 3058 3058
=======================================
Hits 2554 2554
Misses 504 504 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chunk fetching annotations from audioBlast was evaluated as the vignette was built, so R CMD build failed outright wherever the API answers R with a 403, which is the same problem the tests had. The chunk is now eval=FALSE, like the BirdNET chunk below it, as it only demonstrates the call: the object it assigns is reassigned before anything uses it.
R CMD check is now Status: OK, with vignettes built and no NOTEs.