Conversation
katexochen
force-pushed
the
p/runtime-rs
branch
from
6976756 to
b3b8041
Compare
katexochen
force-pushed
the
p/runtime-rs
branch
4 times, most recently
from
642e71f to
6a88531
Compare
| checkFlags = [ | ||
| "--skip=device::device_manager::tests::test_new_block_device" | ||
| "--skip=network::endpoint::endpoints_test::tests::test_ipvlan_construction" | ||
| "--skip=network::endpoint::endpoints_test::tests::test_macvlan_construction" | ||
| "--skip=network::endpoint::endpoints_test::tests::test_vlan_construction" | ||
| "--skip=test::test_new_hypervisor" | ||
| ]; |
There was a problem hiding this comment.
Maybe add a comment that these require root privs (or why they can't be run otherwise).
| # as the node-installer is configured to install this file. | ||
| # TODO(katexochen): Remove when switching to runtime-rs. | ||
| postInstall = '' | ||
| touch $out/bin/kata-runtime |
There was a problem hiding this comment.
I will probably be wondering what that 0-length file is supposed to be a few months down the road. How about populating it with the reason for its absence?
|
|
||
| ./0020-runtime-rs-allow-initrd-AND-image-to-be-set.patch |
There was a problem hiding this comment.
This patch is referenced in 61b7843, but the patch file is only added in a later commit, and with a different index.
| ./0020-shim-guess-CDI-devices-without-direct-match.patch | ||
|
|
||
| # Deny unknown fields where possible to ease migration. This isn't possible where flatten is used. | ||
| # TODO: upstream. |
There was a problem hiding this comment.
I suppose you could link kata-containers/kata-containers#12756 now?
| # Use virtio-blk with serial name for initdata | ||
| # Our initdata-processor expects the initdata device to be present at /dev/disks/by-label/initdata, | ||
| # which requires the device to have a stable name. Using virtio-blk with a serial number achieves this. | ||
| # TODO: check if we can improve the situation upstream or implement a fallback in the initdata-processor. |
There was a problem hiding this comment.
I created kata-containers/kata-containers#12764 for this.
| config.Runtime["experimental"] = []string{"force_guest_pull"} | ||
|
|
||
| config.Agent["kata"]["dial_timeout_ms"] = 1000 | ||
| config.Agent["kata"]["reconnect_timeout_ms"] = 600000 |
There was a problem hiding this comment.
This is likely a debug leftover, right? If not, please leave a comment for why it needs to be that high.
| uses: ./.github/workflows/e2e.yml | ||
| with: | ||
| skip-undeploy: false | ||
| test-name: ${{ matrix.test-name }} | ||
| platform: ${{ matrix.platform.name }} | ||
| runner: ${{ matrix.platform.runner }} | ||
| self-hosted: ${{ matrix.platform.self-hosted }} | ||
| debug-shell: true |
There was a problem hiding this comment.
Don't we need to change the SET?
contrast/.github/workflows/e2e.yml
Lines 54 to 59 in be62ea5
toml parsing in runtime-go and node-installer is case-insensitive, but the crate used in runtime-rs is case sensitive and expects lower-case keys.
Temporary test for runtime-rs that checks the debug shell is started.
2 participants
No description provided.