[15.0][FIX] budget_control_revision: cast revision_number as text instead of char - #598
Merged
Saran440 merged 1 commit intoAug 3, 2026
Conversation
Collaborator
|
Hi @Saran440, |
Pani-k-folk
changed the title
Saran440
approved these changes
Jul 27, 2026
Saran440
left a comment
Saran440
left a comment
Collaborator
There was a problem hiding this comment.
please forward this to v18
Collaborator
|
/ocabot merge patch |
Collaborator
|
This PR looks fantastic, let's merge it! |
Collaborator
|
@Saran440 your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-598-by-Saran440-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Saran440
deleted the
15.0-fix-budget_control_revision-change_char_to_text
branch
August 3, 2026 14:25
Collaborator
|
please forward to v18 too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
::char ใน PSQL คือ character(1) ตัดเหลือตัวอักษรเดียว ทำให้ revision ≥10 ถูก filter ผิดใน _filter_by_budget_control (เช่น revision 11 ถูกอ่านเป็น 1) ส่งผลให้ amount_budget คำนวณผิดเมื่อ budget_control revision ถึงเลข 2 หลัก