Add py39 support and drop py35 support#58
Merged
econchick merged 3 commits intoeconchick:masterfrom Oct 13, 2020
Merged
Conversation
Python 3.9 was released 2020-10-05 https://www.python.org/dev/peps/pep-0596/#id4 and Python 3.5 reached its end of life https://www.python.org/dev/peps/pep-0478/#id4 Thus it would be reasonable to drop py35 support and add py39 support.
s-weigand
force-pushed
the
add-py39-support
branch
from
5013f1c to
e6a2bff
Compare
econchick
reviewed
Oct 6, 2020
Owner
econchick
left a comment
econchick
left a comment
There was a problem hiding this comment.
Thanks for this PR! You're more on top of it than I am ;) just some questions before we proceed any further.
so PyPi will know of the py35 drop
s-weigand
force-pushed
the
add-py39-support
branch
from
dac2bd9 to
9b25986
Compare
Owner
|
FYI this has been released (finally) in 1.3.2 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Out with the old, in with the new. 😄
Motivation and Context
Python 3.9 was released on 2020-10-05 and Python 3.5 reached its end of life
This PR will conflict with #57 , due to changes in
tox.ini