Exclude test_project/ and */tests/ from pip package - #48
Open
atodorov wants to merge 1 commit into
Open
Conversation
atodorov
added a commit
to kiwitcms/github-app
that referenced
this pull request
Jul 15, 2022
atodorov
added a commit
to kiwitcms/github-app
that referenced
this pull request
Jul 15, 2022
atodorov
added a commit
to kiwitcms/github-app
that referenced
this pull request
Jul 15, 2022
atodorov
force-pushed
the
dont_package_test_project
branch
from
September 2, 2022 21:05
ce5b677 to
30ca508
Compare
atodorov
requested review from
chewthemonkey,
delton-ecometrica,
dimitrios-michelakis,
jwilliams-ecometrica,
manos-korakakis,
pauricthelodger,
revenazb and
skazinka
September 2, 2022 21:08
Collaborator
Author
|
Can anyone please review? I am willing to make another PR for version & changelog updates if you're willing to tag a new version and push it to PyPI. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
test_project/package gets installed as part of django-vinaigrette's latest version and I happen to have anothertest_project/locally in my git checkout.The
test_project/that gets installed under site-packages confuses my test setup due to it being imported first and because there's a code snippet which isn't compatible with Django 4. Namelyfrom django.conf.urls import url.Logs: https://github.com/kiwitcms/github-app/runs/7357182169?check_suite_focus=true
This PR excludes everything which is related to testing from the actual pip package.
Please consider cutting a new version.